Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made a sentence slightly more english #5692

Closed
wants to merge 1 commit into from
Closed

Made a sentence slightly more english #5692

wants to merge 1 commit into from

Conversation

GTheron
Copy link
Contributor

@GTheron GTheron commented Sep 14, 2015

Replaced "Even more" with "What's more" to make a sentence "more english".

@GTheron
Made a sentence slightly more english
9c9c93e 
Replaced "Even more" with "What's more" to make a sentence "more english".
@zatikbalazs
Copy link
Contributor

It sounds better indeed.

@javiereguiluz
Copy link
Member

👍 It looks like an easy win. Thanks @GTheron

xabbuh
xabbuh reviewed Sep 23, 2015
View reviewed changes
components/http_foundation/introduction.rst
@@ -464,7 +464,7 @@ represented by a PHP callable instead of a string::
you must call ``ob_flush()`` before ``flush()``.

Additionally, PHP isn't the only layer that can buffer output. Your web
server might also buffer based on its configuration. Even more, if you
server might also buffer based on its configuration. What's more, if you
use fastcgi, buffering can't be disabled at all.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can also change "fastcgi" to "FastCGI".

@xabbuh
Copy link
Member

xabbuh commented Sep 23, 2015

👍

@xabbuh
Copy link
Member

xabbuh commented Sep 23, 2015

Thank you Gabriel.

xabbuh added a commit that referenced this pull request Sep 23, 2015
@xabbuh
minor #5692 Made a sentence slightly more english (GTheron)
7960ed8 
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5692).

Discussion
----------

Made a sentence slightly more english

Replaced "Even more" with "What's more" to make a sentence "more english".

Commits
-------

13d3a99 Made a sentence slightly more english
@xabbuh xabbuh closed this Sep 23, 2015
@xabbuh
Copy link
Member

xabbuh commented Sep 23, 2015

@GTheron I merged your change into the 2.3 branch (that's why it is shown as closed) and made the tweak to "fastcgi" in 6b5de8c.

@GTheron
Copy link
Contributor Author

GTheron commented Sep 23, 2015

Brilliant, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GTheron @zatikbalazs @javiereguiluz @xabbuh