[Cookbook][Security] clarify description of the getPosition() method #5767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Oct 7, 2015
xabbuh
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets |
| @@ -354,8 +354,8 @@ requires the following methods: | |||
| to the DI container for the appropriate security context. | |||
|
|
|||
| ``getPosition`` | |||
| Method which must be of type ``pre_auth``, ``form``, ``http``, | |||
| and ``remember_me`` and defines the position at which the provider is called. | |||
| Method which defines the position at which the provider is called. The | |||
There was a problem hiding this comment.
What about: "Returns when the provider should be called. This can be one of pre_auth, form, http or remember_me."
weaverryan
added a commit
that referenced
this pull request
Nov 5, 2015
…on() method (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Cookbook][Security] clarify description of the getPosition() method | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | Commits ------- 74771b7 clarify description of the getPosition() method
|
@wouterj Sorry, I missed your comment. Do you think we should make that change? |
|
No worries - I did it. Working with limited internet, so I didn't post here about that :) |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.