added app_ prefix to form type names #5798
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1173,7 +1173,7 @@ easy to use in your application. | |||
|
|
|||
| # src/AppBundle/Resources/config/services.yml | |||
| services: | |||
| app.form.type.task: | |||
| app.form.type.app_task: | |||
There was a problem hiding this comment.
I would not change this here (we already have the app. prefix).
There was a problem hiding this comment.
ok, i changed the code
|
We should make this change in the |
OskarStark
force-pushed
the
streamline_form_type_names
branch
from
1e78371 to
2ef2567
Compare
OskarStark
force-pushed
the
streamline_form_type_names
branch
from
2ef2567 to
3fa821a
Compare
|
any news on this PR? |
| @@ -311,14 +311,14 @@ the ``genders`` parameter value as the first argument to its to-be-created | |||
| arguments: | |||
| - "%genders%" | |||
| tags: | |||
| - { name: form.type, alias: gender } | |||
| - { name: form.type, alias: app_gender } | |||
There was a problem hiding this comment.
The getName() bundle at the top of the article must be updated too.
|
I've rebased this PR on top of 2.3 and updated the Thank you for fixing this @OskarStark! 🎄 |
|
Good Job 👍 Am Samstag, 19. Dezember 2015 schrieb Wouter J :
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #5077
I'm not really sure about the changes of the
aliasnames...ping @xabbuh
Greetings from Symfony Live Berlin 2015 - Hack Day 😄