Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CssSelector code example to use the new Converter #5835

Merged
merged 3 commits into from
Nov 5, 2015
Merged

Updated CssSelector code example to use the new Converter #5835

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9392f80
Updated CssSelector code example to use the new Converter
hiddewie Oct 24, 2015
df4fc7e
Updated for CssSelectorConverter class name
hiddewie Oct 25, 2015
dfb9b16
Used :: for code block
hiddewie Oct 25, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions components/css_selector.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,14 @@ The CssSelector Component
~~~~~~~~~~~~~~~~~~~~~~~~~

The component's only goal is to convert CSS selectors to their XPath
equivalents::
equivalents, using :method:`Converter::toXPath() <Symfony\\Component\\CssSelector\\Converter::toXPath>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to use a special text for the link IMO. Just use :method:Symfony\Component\CssSelector\CssSelectorConverter::toXPath``


use Symfony\Component\CssSelector\CssSelector;
.. code-block:: php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should still use the double colon at the end of the previous paragraph and omit the code-block directive here.


var_dump(CssSelector::toXPath('div.item > h4 > a'));
use Symfony\Component\CssSelector\Converter;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class has been renamed to CssSelectorConverter after the initial merge. So this update is wrong


$converter = new Converter();
var_dump($converter->toXPath('div.item > h4 > a'));

This gives the following output:

Expand Down