Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo #5850

Closed
wants to merge 2 commits into from
Closed

Fixed typo #5850

wants to merge 2 commits into from

Conversation

tobiassjosten
Copy link
Contributor

Comparing events to subscribers doesn't make much sense, so I figured it must be a typo.

@@ -248,7 +248,7 @@ or a "sub request"::
Certain things, like checking information on the *real* request, may not need to
be done on the sub-request listeners.

Events or Subscribers
Listeners or Subscribers
---------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we need as many dash characters as the length of the headline.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we should add a label for the old headline before the new one to keep the old anchor too:

.. _events-or-subscribers:

Listeners or Subscribers
------------------------

@xabbuh
Copy link
Member

xabbuh commented Oct 29, 2015

@tobiassjosten Good catch! I just left two minor comments.

@tobiassjosten
Copy link
Contributor Author

@xabbuh Fixed!

Not too familiar with rST but I'm guessing the new header doesn't need an explicit label?

@xabbuh
Copy link
Member

xabbuh commented Oct 30, 2015

Great! 👍

And yes, we don't need to add one for the new headline. The label is only needed for the old headline so that people can still refer to this headline with old bookmarks, for example.

xabbuh added a commit that referenced this pull request Nov 1, 2015
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #5850).

Discussion
----------

Fixed typo

Comparing events to subscribers doesn't make much sense, so I figured it must be a typo.

Commits
-------

6e220ef Fixed typo
@xabbuh
Copy link
Member

xabbuh commented Nov 1, 2015

Good catch Tobias. I have merged your changes into the 2.3 branch and then up into all other maintained branches. That's why your pull request is shown as closed.

@xabbuh xabbuh closed this Nov 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants