-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed typo #5850
Fixed typo #5850
Conversation
@@ -248,7 +248,7 @@ or a "sub request":: | |||
Certain things, like checking information on the *real* request, may not need to | |||
be done on the sub-request listeners. | |||
|
|||
Events or Subscribers | |||
Listeners or Subscribers | |||
--------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we need as many dash characters as the length of the headline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And we should add a label for the old headline before the new one to keep the old anchor too:
.. _events-or-subscribers:
Listeners or Subscribers
------------------------
@tobiassjosten Good catch! I just left two minor comments. |
@xabbuh Fixed! Not too familiar with rST but I'm guessing the new header doesn't need an explicit label? |
Great! 👍 And yes, we don't need to add one for the new headline. The label is only needed for the old headline so that people can still refer to this headline with old bookmarks, for example. |
Good catch Tobias. I have merged your changes into the |
Comparing events to subscribers doesn't make much sense, so I figured it must be a typo.