Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Book] Do not extend the base controller before introducing it #5979

Merged
merged 1 commit into from
Dec 9, 2015
Merged

[Book] Do not extend the base controller before introducing it #5979

merged 1 commit into from
Dec 9, 2015

Conversation

ogizanagi
Copy link
Contributor

Q A
Doc fix? yes
New docs? no
Applies to 2.3+
Fixed tickets #5969

@javiereguiluz
Copy link
Member

👍 It totally makes sense to me. Thanks @ogizanagi

@xabbuh
Copy link
Member

xabbuh commented Dec 8, 2015

👍

@xabbuh
Copy link
Member

xabbuh commented Dec 9, 2015

Thank you @ogizanagi.

@xabbuh xabbuh merged commit 98c4525 into symfony:2.3 Dec 9, 2015
xabbuh added a commit that referenced this pull request Dec 9, 2015
@xabbuh
minor #5979 [Book] Do not extend the base controller before introduci…
e48c528 
…ng it (ogizanagi)

This PR was merged into the 2.3 branch.

Discussion
----------

[Book] Do not extend the base controller before introducing it

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3+
| Fixed tickets | #5969

Commits
-------

98c4525 [Book] Do not extend the base controller before introducing it
@ogizanagi ogizanagi deleted the 5969_base_controller_extends branch December 9, 2015 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ogizanagi @javiereguiluz @xabbuh