[Book] use AppBundle examples and follow best practices #6006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Dec 13, 2015
xabbuh
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets |
| @@ -348,12 +348,12 @@ directories don't exist, create them. | |||
|
|
|||
| # src/Acme/HelloBundle/Resources/config/services.yml | |||
| parameters: | |||
| my_mailer.transport: sendmail | |||
| app.mailer.transport: sendmail | |||
There was a problem hiding this comment.
Very small detail: 2 spaces before "sendmail"
|
@xabbuh very nice changes. Thank you! |
xabbuh
force-pushed
the
acme-app-bundle
branch
from
96bb857
to
2394e3f
Compare
|
Cool! 👍 |
wouterj
added a commit
that referenced
this pull request
Dec 17, 2015
…xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Book] use AppBundle examples and follow best practices | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | Commits ------- 2394e3f use AppBundle examples and follow best practices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.