clarify the routing component documentation a bit #6023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dbu
commented
Dec 16, 2015
dbu
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.3+ |
| Fixed tickets | Relates to #5709 |
| @@ -62,11 +62,15 @@ URL path and some array of custom variables in its constructor. This array | |||
| of custom variables can be *anything* that's significant to your application, | |||
| and is returned when that route is matched. | |||
|
|
|||
| If no matching route can be found a | |||
| :class:`Symfony\\Component\\Routing\\Exception\\ResourceNotFoundException` will be thrown. | |||
| The :method:``UrlMatcher::match() <Symfony\\Component\\Routing\\UrlMatcher::match`` | |||
There was a problem hiding this comment.
and double backticks should be single ones
|
fixed |
|
👍 |
|
anything left to do here or can this be merged? |
|
@javiereguiluz @weaverryan @wouterj What do you think? |
|
|
||
| In addition to your array of custom variables, a ``_route`` key is added, | ||
| which holds the name of the matched route. | ||
| If no matching route can be found during ``match``, a |
There was a problem hiding this comment.
I'd remove during match because it looks redundant.
|
Nice job @dbu, thanks :) |
weaverryan
added a commit
that referenced
this pull request
Jan 10, 2016
This PR was merged into the 2.3 branch. Discussion ---------- clarify the routing component documentation a bit | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | Relates to #5709 Commits ------- 940fb8f clarify the routing component documentation a bit
weaverryan
added a commit
that referenced
this pull request
Jan 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.