added a sentence about the HttpException::setHeaders method #6076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
smatyas
force-pushed
the
http_exceptions_headers
branch
from
00499a6 to
37bdf76
Compare
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jan 25, 2016
…n the HttpException (smatyas) This PR was submitted for the 2.8 branch but it was merged into the 3.1-dev branch instead (closes #17111). Discussion ---------- [HttpKernel] added a setter for the headers property in the HttpException | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#6076 Added this setter, because it's now impossible to use those handy, meaningful, already implemented exceptions (like NotFound...) if one wants to set some custom headers. This PR solves this problem. It's a backward compatible solution in this way, but maybe it would be better if the `HttpExceptionInterface` would contain the `setHeaders` function as well. Of course this would be a BC break, that's why it is missing now. TODO: - [x] submit changes to the documentation Commits ------- 6a1080f [HttpKernel] added a setter for the headers property in the HttpException
|
The upstream PR has been merged now, 👍 |
|
Thank you @smatyas. I have merged your PR into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a doc. change related to the linked symfony PR.