Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace references of PSR-0 with PSR-4 #6208

Closed
wants to merge 2 commits into from
Closed

Replace references of PSR-0 with PSR-4 #6208

wants to merge 2 commits into from

Conversation

opdavies
Copy link
Contributor

No description provided.

wouterj
wouterj reviewed Jan 31, 2016
View reviewed changes
create_framework/http_foundation.rst
@@ -309,5 +309,5 @@ applications using it (like `Symfony`_, `Drupal 8`_, `phpBB 4`_, `ezPublish
.. _`Midgard CMS`: http://www.midgard-project.org/
.. _`Zikula`: http://zikula.org/
.. _`autoloaded`: http://php.net/autoload
.. _`PSR-0`: https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-0.md
.. _`PSR-4`: https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-4-autoloader.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, but if you can make this change it would be great: Let's change this URL to the official site: http://www.php-fig.org/psr/psr-4/

@wouterj
Copy link
Member

wouterj commented Jan 31, 2016

👍 (if you can include the suggested change in this PR, great! Otherwise we'll do it after merging).

@opdavies
Copy link
Contributor Author

Done. 😄

@xabbuh
Copy link
Member

xabbuh commented Feb 1, 2016

Shouldn't we mention both PSR-0 and PSR-4 here?

@opdavies
Copy link
Contributor Author

opdavies commented Feb 2, 2016

@xabbuh I thought that it would be better to remove PSR-0 as it's deprecated, but I'm happy to be convinced otherwise.

xabbuh added a commit that referenced this pull request Feb 5, 2016
@xabbuh
minor #6208 Replace references of PSR-0 with PSR-4 (opdavies)
ccbce6e 
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #6208).

Discussion
----------

Replace references of PSR-0 with PSR-4

Commits
-------

2efbcbf Replace references of PSR-0 with PSR-4
@xabbuh
Copy link
Member

xabbuh commented Feb 5, 2016

Yeah, I think you are right. Technically, Composer supports both but there's probably no need in the Symfony context to mention that.

FYI, I have squashed your changes and merged them into the 2.3 branch. That's why the PR is shown as closed instead of merged. But you will still get the full credit for your work. Thanks!

@xabbuh xabbuh closed this Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@opdavies @wouterj @xabbuh