path() explanation inside templating + Minor formatting changes #6218
Conversation
Format "AppBundle" inside the example table for controller short names.
Mention that "path()" generates relative URLs. Take out an "=" sign out of code syntax. Single quotes instead of double ones in javascript example.
Minor formatting change for value inside table
| @@ -1461,7 +1461,7 @@ system. Take the ``blog_show`` example route from earlier:: | |||
| // /blog/my-blog-post | |||
|
|
|||
| To generate a URL, you need to specify the name of the route (e.g. ``blog_show``) | |||
| and any wildcards (e.g. ``slug = my-blog-post``) used in the path for that | |||
| and any wildcards (e.g. ``slug`` = ``my-blog-post``) used in the path for that | |||
There was a problem hiding this comment.
no, we would like to point out the whole expression, so the = belongs to it
There was a problem hiding this comment.
For me, it looks like an assignment operation. :)
| @@ -1547,6 +1547,8 @@ a template helper function: | |||
| The ``path()`` PHP templating helper was introduced in Symfony 2.8. Prior | |||
| to 2.8, you had to use the ``generate()`` helper method. | |||
|
|
|||
| The ``path()`` method generates relative URLs. | |||
There was a problem hiding this comment.
I think we should "blend" this into the paragraph before the code block, instead of a lost sentence somewhere at the end of the section. What about changing the paragraph to:
The most common place to generate a URL is from within a template when linking
between pages in your application. This is done just as before, but using
- a template helper function:
+ the ``path()`` function to generate a relative URI:
|
@sfdumi do you have some time to finish this PR? It does also need a rebase as some changes are conflicting now. If you don't have much time or need some help, feel free to comment and we'll take it over from here. |
|
I can do the changes, but it is not clear for all of them if they should be done or not (eg: the first one). @wouterj can you please clarify what needs to be done? |
…hanges (sfdumi) This PR was submitted for the 3.0 branch but it was merged into the 2.7 branch instead (closes #6218). Discussion ---------- path() explanation inside templating + Minor formatting changes Mention that "path()" generates relative URLs. Take out an "=" sign out of code syntax. Single quotes instead of double ones in javascript example. Format "AppBundle" inside the example table for controller short names. Commits ------- c868c5a path() explanation inside templating + Minor formatting changes
|
Hi @sfdumi! I'm sorry that it took so long before I came back to this PR. Because of this, I've directly merged your PR and made some minor changes afterwards in 25ac5fe. Your PR is merged into the 2.7 version (the oldest still maintained version). I'll merge it in the newer versions from there. Thanks! |
Mention that "path()" generates relative URLs.
Take out an "=" sign out of code syntax.
Single quotes instead of double ones in javascript example.
Format "AppBundle" inside the example table for controller short names.