Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note to create a service if you extend ExceptionController #6224

Closed
wants to merge 3 commits into from
Closed

Note to create a service if you extend ExceptionController #6224

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e932f8
Note to create a service if you extend ExceptionController
pamuche Feb 4, 2016
0ecf2e0
Integrate recommended changes
pamuche Feb 5, 2016
e80cf46
Adds one forgotten change
pamuche Feb 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion cookbook/controller/error_pages.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,25 @@ will be passed two parameters:
Instead of creating a new exception controller from scratch you can, of course,
also extend the default :class:`Symfony\\Bundle\\TwigBundle\\Controller\\ExceptionController`.
In that case, you might want to override one or both of the ``showAction()`` and
``findTemplate()`` methods. The latter one locates the template to be used.
``findTemplate()`` methods. The latter one locates the template to be used.

.. note::

In case of extending the :class:`Symfony\\Bundle\\TwigBundle\\Controller\\ExceptionController`
you may configure a service to pass the twig-Environment and the debug-Flag to the constructor.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would replace this:

twig-Environment and the debug-Flag

by this:

Twig environment and the ``debug`` flag


.. configuration-block::

.. code-block:: yaml

# app/config/config.yml
services:
my_custom_exception_controller_service:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In modern Symfony apps, we recommend to use shorter service names. What about replacing my_custom_exception_controller_service by app.exception_controller ?

class: AppBundle\CustomExceptionController
arguments: [ "@twig", "%kernel.debug%" ]

twig:
exception_controller: my_custom_exception_controller_service:showAction

.. tip::

Expand Down