Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cookbook][Doctrine] some tweaks to the Doctrine registration article #6255

Merged
merged 1 commit into from
Feb 15, 2016

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Feb 10, 2016

No description provided.

@wouterj
Copy link
Member

wouterj commented Feb 10, 2016

👍

1 similar comment
@javiereguiluz
Copy link
Member

👍

use AppBundle\Form\UserType;
use AppBundle\Entity\User;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Sensio" could go before "Symfony" to keep the alphabetical order.

Same for line 46 can be the last.

Line 250 "[...] like sending [...] ?
Line 414 shouldn't it be "[...] Symfony knows how to [...]"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I have made these tweaks in 44d7479

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I was not sure I should mention it

@xabbuh xabbuh merged commit 999e783 into symfony:2.3 Feb 15, 2016
xabbuh added a commit that referenced this pull request Feb 15, 2016
…tion article (xabbuh)

This PR was merged into the 2.3 branch.

Discussion
----------

[Cookbook][Doctrine] some tweaks to the Doctrine registration article

Commits
-------

999e783 some tweaks to the Doctrine registration article
@xabbuh xabbuh deleted the doctrine-registration-tweaks branch February 15, 2016 20:09
xabbuh added a commit that referenced this pull request Feb 15, 2016
xabbuh added a commit that referenced this pull request Feb 17, 2016
* 2.3:
  [#6278] small tweak
  [HttpFoundation] Fix typo for ParameterBag getters
  Updated third param true to UrlGeneratorInterface::ABSOLUTE_URl in text Generating Absolute URLs
  fix yaml syntax
  [#6255] some tweaks
  Rewrite EventDispatcher introduction
  Fixed code example
  some tweaks to the Doctrine registration article
  mention routing from the database

Conflicts:
	components/event_dispatcher/introduction.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants