-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[book] Updated link to Translatable Extension #6362
Conversation
Since l3pp4rd project was moved it is better to provide link to the new project. Moreover, I think it is better to show the exact page of Translatable Extension instead of a list of extensions.
A quick win and a nice improvement! @AAstakhov thanks for helping us improve the Symfony docs. |
Thanks for the heads up @AAstakhov. However, I'd say let's link to the rendered docs on http://atlantic18.github.io/DoctrineExtensions/doc/translatable.html. |
Replaced link to Translatable Extension to rendered documentation.
@xabbuh, agree |
👍 |
I don't think promote the old (and buggy) Gedmo implementation is a good idea, KNP is simpler and better. |
@webda2l Would you like to open a new issue for that? We can, of course, discuss to promote another library but we should discuss that apart from this PR which just fixes the link. |
This is just that this PR "Updated link" could become "Remove link", but more people should give their opinion. |
Perhaps @docteurklein can tell us about https://github.com/KnpLabs/DoctrineBehaviors and it we should link there instead - I have also heard good things :) |
This PR was merged into the 2.3 branch. Discussion ---------- [book] Updated link to Translatable Extension | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | n/a Since l3pp4rd project was moved it is better to provide link to the new project. Moreover, I think it is better to show the exact page of Translatable Extension instead of a list of extensions. Commits ------- b273c67 Updated link to Translatable Extension b4adf83 Updated link to Translatable Extension
I didn't have a good experience with gedmo translation (specifically) extension neither. KnpLabs/DoctrineBehaviors tries to stick as much as possible to use ORM associations. I'm not sure about the other behaviors in the same package (softDeletable f.e), but translatable is pretty solid. |
Since l3pp4rd project was moved it is better to provide link to the new project. Moreover, I think it is better to show the exact page of Translatable Extension instead of a list of extensions.