Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo #6370

Closed
wants to merge 1 commit into from
Closed

Fixed typo #6370

wants to merge 1 commit into from

Conversation

tabbi89
Copy link
Contributor

@tabbi89 tabbi89 commented Mar 14, 2016

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets -

@javiereguiluz
Copy link
Member

@tabbi89 nice catch! Thanks for fixing this error.

A minor comment for your next pull requests: the pull request must be created against the oldest Symfony branch which is still maintained and suffers the error. In this case, you selected 3.0 branch, but the oldest maintained branch (which is 2.3) also suffers the error. So this pull request should have been created based on 2.3.

But don't worry this time. The change is small enough so our doc managers will do some magic to change the branch when merging it. Thanks!

@tabbi89
Copy link
Contributor Author

tabbi89 commented Mar 14, 2016

Thanks, next time I will choose the right branch.

@xabbuh
Copy link
Member

xabbuh commented Mar 15, 2016

Good catch, thanks @tabbi89.

xabbuh added a commit that referenced this pull request Mar 15, 2016
@xabbuh
minor #6370 Fixed typo (tabbi89)
7a34214 
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes #6370).

Discussion
----------

Fixed typo

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | -

Commits
-------

c68c61a Fixed typo
@xabbuh xabbuh closed this Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tabbi89 @javiereguiluz @xabbuh