Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the docs for the @dns-sensitive mocks #6388

Closed
wants to merge 3 commits into from

Conversation

javiereguiluz
Copy link
Member

This fixes #6379.

---------------

The ``@group time-sensitive`` and ``@group dns-sensitive`` annotations work
"by convention" and assumes that the namespace of the tested class can be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo "assume" ?

@stof
Copy link
Member

stof commented Mar 24, 2016

@javiereguiluz given that the bridge has more and more features, wouldn't it be better to split its doc into multiple chapters instead, as done for other components ?

~~~~~~~~~~~~~~~
DNS-sensitive Tests
-------------------

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing versionadded

@javiereguiluz
Copy link
Member Author

I've changed everything reviewers suggested. I also agree with @stof and we should split this doc as soon as we try to add the explanation of a new feature.

@javiereguiluz
Copy link
Member Author

Ready for the final review before merge. Thanks!

@xabbuh
Copy link
Member

xabbuh commented Apr 1, 2016

👍

@stof
Copy link
Member

stof commented Apr 1, 2016

we should split this doc as soon as we try to add the explanation of a new feature.

As this PR is adding explanations of new features, I would say it is time 😄

@javiereguiluz
Copy link
Member Author

@stof I was referring to new explanations after this feature 😁

@xabbuh
Copy link
Member

xabbuh commented Apr 3, 2016

I am 👍 for merging this as is. If someone feels the need to split the component's documentation with this feature set, we can discuss that in a new PR, but don't block merging this one because of a new discussion.

DNS-sensitive Tests
-------------------

.. versionadded:: 2.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. versionadded:: 3.1 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks!

@wouterj
Copy link
Member

wouterj commented Apr 10, 2016

Thanks for the quick fixes, Javier!

@wouterj wouterj closed this in bdacf53 Apr 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PhpUnitBridge] Mock DNS functions
5 participants