Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix RequestDataCollector class namespace #6568

Merged
merged 1 commit into from
May 14, 2016
Merged

fix RequestDataCollector class namespace #6568

merged 1 commit into from
May 14, 2016

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented May 14, 2016

This fixes #6565.

@xabbuh xabbuh mentioned this pull request May 14, 2016
Closed
@wouterj
Copy link
Member

wouterj commented May 14, 2016

👍

@wouterj wouterj merged commit d535d32 into symfony:2.3 May 14, 2016
wouterj added a commit that referenced this pull request May 14, 2016
@wouterj
minor #6568 fix RequestDataCollector class namespace (xabbuh)
19cc887 
This PR was merged into the 2.3 branch.

Discussion
----------

fix RequestDataCollector class namespace

This fixes #6565.

Commits
-------

d535d32 fix RequestDataCollector class namespace
HeahDude
HeahDude reviewed May 14, 2016
View reviewed changes
reference/events.rst
@@ -77,7 +77,7 @@ This is the built-in Symfony listener related to this event:
============================================================================== ========
Listener Class Name Priority
============================================================================== ========
:class:`Symfony\\Bundle\\FrameworkBundle\\DataCollector\\RequestDataCollector` 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this class is here, but it was added in 3.1 with symfony/symfony#17589. Does it worth reverting it in master?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, see #6569

@xabbuh xabbuh deleted the request-data-collector-api-link branch May 15, 2016 07:08
@xabbuh xabbuh mentioned this pull request May 15, 2016
Merged
wouterj added a commit that referenced this pull request May 21, 2016
@wouterj
minor #6569 [Reference] change namespace to point to new class (xabbuh)
9363cd3 
This PR was merged into the 3.1 branch.

Discussion
----------

[Reference] change namespace to point to new class

see symfony/symfony#17589 and #6568 (comment)

Commits
-------

10cf8d6 change namespace to point to new class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @wouterj @HeahDude