Routes should be just imported, not mounted #6612
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It just causes me headache to figure out why the routes behave so weirdly even if you follow the cookbook 1:1 :-).
When calling
mount()
on already imported routes (what is stated in the cookbook), the router behaves a bit weirdly and mounts the routes in this way:Basically the prefixes are doubled, what is definitely not intended. While the behavior of the
RouteCollectionBuilder
is kinda weird, I rather think this is a just misuse of themount()
method - which is not needed and is probably not expected to be called on already imported and mounted routes.Moreover, the import of annotation routes works just by coincidence - the second parameter of
import()
is prefix, not type, so the routes are added with prefix "/annotation" and only because the mount is used, they appears as mounted to "/" prefix.Cc @weaverryan