[WSSE] - Using a PSR6 cache instead of file cache #6617
Conversation
| @@ -127,7 +127,7 @@ set an authenticated token in the token storage if successful. | |||
|
|
|||
| public function __construct(TokenStorageInterface $tokenStorage, AuthenticationManagerInterface $authenticationManager) | |||
| { | |||
| $this->tokenStorage = $tokenStorage; | |||
| $this->tokenStorage = $tokenStorage; | |||
There was a problem hiding this comment.
Please revert this change (we do not align assignments in Symfony).
There was a problem hiding this comment.
Sorry. I looked at the other constructor on this page where you do align it. I'll revert it. Thank you.
|
I basically like the idea to make use of the new Cache component in this example. Thanks for the heads up @Nyholm! I just left some minor comments about changes we should imo make to better fit with how the PSR-6 cache system is integrated in Symfony. |
|
@weaverryan @wouterj By the way, we need to pay attention to merge this into the |
|
Thank you for your comments. I'll update the pr tomorrow. |
|
I've just pushed some changes to the PR. |
|
👍 Great work @Nyholm! |
|
Thanks Tobias, this looks very nice! |
This PR was submitted for the 3.0 branch but it was merged into the 3.1 branch instead (closes #6617). Discussion ---------- [WSSE] - Using a PSR6 cache instead of file cache I rewrote the WSSE example to use a PSR-6 cache instead. I did this because Symfony got a fancy new CacheComponent now and because using file cache will eventually fill up your inodes. (I just removed 2 million inodes from my server.) Note: Im not sure about the service name for a cache pool. Is it just `cache`? Commits ------- 1d6e267 [WSSE] - Using a PSR6 cache instead of file cache
|
Thank you for merging. |
I rewrote the WSSE example to use a PSR-6 cache instead. I did this because Symfony got a fancy new CacheComponent now and because using file cache will eventually fill up your inodes. (I just removed 2 million inodes from my server.)
Note: Im not sure about the service name for a cache pool. Is it just
cache?