Fix wrong variable name in comment #6619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The object being updated via deserialize is $person, but in the comment it was wrongly referred to as $obj2
|
👍 |
|
👍 |
|
Thanks Francesco! Fyi, I've merged this into 2.7 (the oldest version this bug existed in). I'll take care of bringing it into the newer versions. |
wouterj
added a commit
that referenced
this pull request
May 27, 2016
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #6619). Discussion ---------- Fix wrong variable name in comment The object being updated via deserialize is $person, but in the comment it was wrongly referred to as $obj2 Commits ------- 682bb81 Fix wrong variable name in comment
|
@wouterj ok thank you! Sorry I did not think to check against older versions, next time just remind me and I will take care of it :-) |
|
@zanardigit no worries, with our merge tool, it's just as simple as passing |
|
@wouterj you can even shorten it as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The object being updated via deserialize is $person, but in the comment it was wrongly referred to as $obj2