Fix for #6625 #6628
Closed
Fix for #6625 #6628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix adds a recommendation of installing PHPUnit as a PHAR archive, as suggested in symfony#6625.
|
👍 |
|
Thanks @kix for taking the time to submit this PR, it looks like the root problem has been fixed: phpspec/prophecy#275 |
|
I think that this PR can be closed, PHPUnit can be installed on Symfony 3.1 since the new release of Prophecy this morning. |
|
Imo it's still a good idea to recommend not to add PHPUnit to the project's requirements. |
|
I agree with @xabbuh. Thanks for fixing this Stepan! |
| to use version 4.2 or higher to test the Symfony core code itself). | ||
| It's recommended to use the latest stable PHPUnit version, `installed as | ||
| PHAR`_ (you will have to use version 4.2 or higher to test the Symfony core | ||
| code itself). |
There was a problem hiding this comment.
Oh well, now that I look at this again: I think we should remove the note about the core as testing Symfony itself is a bit different (we have our own PHPUnit wrapper script).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix adds a recommendation of installing PHPUnit as a PHAR archive, as suggested in #6625.