Added info on doctrine metadata implications on validation #6649
Conversation
It took me a while to figure this out. So I think it should be explained *somewhere*. I'm not sure if this is the right place, and I'm also not sure if the information is comprehensive. Just wanted to get somehing going about 'Doctrine and validation' somewhere in the docs.
|
This feature is actually provided by type guessers (especially the Doctrine ORM one). It does not only work for the It's more or less explained in Creating a custom Type Guesser. |
|
I'm not sure that we're talking about the same thing. When I create a form like here: http://symfony.com/doc/current/book/forms.html#creating-form-classes The DoctrineOrmTypeGuesser, is this enabled by default? If no, where do I have to enable it? |
|
@ThomasLandauer : I confirm we're talking about the same thing. Types guessers are not about validation, they guess the form type to use and some attributes like See: Input type, required, max length & pattern html attributes are guessed thanks to them. The |
|
OK, my point is: Being a smart framework, I (personally) would have expected that Symfony automatically uses my Doctrine metadata for validation (i.e. true server-side validation). Since this is not the case, I think it should be explained somewhere that the user is expected to repeat the ORM rules in validation.yml. I think the entire Forms chapter should be reorganised, prioritizing more on real use-cases (like this one, namely binding a form to a database entity) and less on exotic features like forms with multiple submit buttons. In other words: Before you can tell people about validation groups, you should tell them how validation works at all :-) I don't insist on my particular wording, neither on this very location. But, again, since binding a form to a database entity is a standard use-case, it should be explained somewhere how validation works in this case. |
|
Hey guys! Catching up on some old PR's :). I definitely agree with you @ThomasLandauer, and when I went through the current docs (which have been restructured already in many of the ways you suggested), I found out that I think we now have this covered: the forms chapter talks about field option guessing, what it does, and how it works: http://symfony.com/doc/current/forms.html#field-type-options-guessing. And, this conversation comes after talking about real, server-side validation. So, I'm going to close this PR as finished - please feel free to open a PR if you think we could clarify further. Thanks! |
* 2.7: [#6925] Removing more instances of the deprecated getMock() Minor language tweaks removing cookbook entries updating links Moving files into the new structure [#6649] Changing a note to a caution - this *is* a gotcha fix typo Typo in the class name. Fixed indentation issues in alias_private article [Serializer] Document the encoders
* 2.8: (32 commits) [#6925] Removing more instances of the deprecated getMock() Method "$this->getMock()" is depreciated Minor language tweaks removing cookbook entries updating links Moving files into the new structure [#6649] Changing a note to a caution - this *is* a gotcha fix typo Typo in the class name. Update tags.rst Fixed indentation issues in alias_private article Fix the error in code example [Controller Description] Remove backticks [Controller] Fix nested inline markup [Controller Description] Fix typos and class link Fix var_dumper advanced usage link [#6908] Add deprecations on some other places as well Add deprecation warnings to relevant profiler options Update access_control.rst DumpFile() third argument is deprecated and doesn't exists anymore in 3.x ...
* 3.0: [#6925] Removing more instances of the deprecated getMock() Method "$this->getMock()" is depreciated Minor language tweaks removing cookbook entries updating links Moving files into the new structure [#6649] Changing a note to a caution - this *is* a gotcha fix typo Typo in the class name. Update tags.rst Fixed indentation issues in alias_private article [Serializer] Document the encoders
|
Um, now the entire "Forms and Doctrine" subsection (https://github.com/ThomasLandauer/symfony-docs/blob/dbe120598ca6fd38b38adff456a2247d3849645b/book/forms.rst#forms-and-doctrine) of the forms chapter is gone! So while being better in general, the new version of the chapter is even worse than the old one, regarding the interplay with Doctrine. Which is the most widely used use-case of a form, after all. |
It took me a while to figure this out. So I think it should be explained somewhere. I'm not sure if this is the right place, and I'm also not sure if the information is comprehensive.
Just wanted to get somehing going about 'Doctrine and validation' somewhere in the docs.