Finder::path() method matching directories and files
#6652
Conversation
| @@ -222,6 +222,11 @@ and adding delimiters: | |||
| The :method:`Symfony\\Component\\Finder\\Finder::notPath` method excludes files by path:: | |||
|
|
|||
| $finder->notPath('other/dir'); | |||
|
|
|||
| The method :method:`Symfony\\Component\\Finder\\Finder::path` will match both directories and files. For example, the following will match ``foo/bar.yml`` but also ``foo.yml``:: | |||
There was a problem hiding this comment.
will match both directories and files -> matches both directories and files
| @@ -223,6 +223,11 @@ The :method:`Symfony\\Component\\Finder\\Finder::notPath` method excludes files | |||
|
|
|||
| $finder->notPath('other/dir'); | |||
|
|
|||
| The method :method:`Symfony\\Component\\Finder\\Finder::path` matches both directories and files. For example, the following will match ``foo/bar.yml`` but also ``foo.yml``:: | |||
There was a problem hiding this comment.
I would move the word "method" after the method name.
There was a problem hiding this comment.
And can you please wrap the paragraph after the first line that crosses the 72nd character?
|
Hi @soyuka! What about changing the code example on line 205 with something like this instead: - $finder->path('some/special/dir');
+ // matches files in the data/ directory and its subdirectories.
+ $finder->path('data');I don't think we should add a whole new paragraph and code example for such information. It can perfectly be included in the code example imo. However, I would like to hear your and others opinions about it. If you agree, can you please update the PR? Status: needs work |
|
My point is that, Saying:
isn't sufficient imo, because it'll also match a |
|
@javiereguiluz +1, but may we add an example that combines // matches files that contain "data" anywhere in their paths (files or directories)
$finder->path('data');
// for example this will match data/*.xml and data.xml if they exists
$finder->path('data')->name('*.xml'); |
|
@soyuka +1 I like your proposal because to me this looks impossible to explain in just 1 sentence. |
|
Actually, after reading your proposal, it's the first time I understand the problem this PR tries to solve. 👍 to update the example with that. Can you please update your PR? |
|
Github does weird things sorry about that, updated with my last example l205 and removed the previous paragraph. |
| // matches files that contain "data" anywhere in their paths (files or directories) | ||
| $finder->path('data'); | ||
| // for example this will match data/*.xml and data.xml if they exist | ||
| $finder->path('data')->name('*.xml'); |
There was a problem hiding this comment.
please indent the code example with 4 spaces. (if I count correctly, it's 2 spaces at the moment).
|
👍 Status: Reviewed |
|
👍 |
|
Thank you @soyuka. |
…oyuka) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #6652). Discussion ---------- `Finder::path()` method matching directories and files For clarity, adds an example where `path()` is used to match a directory or a file. ref api-platform/core#575 (comment) Commits ------- cd28675 Improve `Finder::path` code example about resulting matches
For clarity, adds an example where
path()is used to match a directory or a file.ref api-platform/core#575 (comment)