Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Contributing][Code] fix list item terminators #6667

Merged
merged 1 commit into from
Jun 21, 2016

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 21, 2016

No description provided.

@javiereguiluz
Copy link
Member

👍

By the way, we need to update this document to replace all the should be by must be

@xabbuh xabbuh force-pushed the contributing-items branch from 1d44b63 to 2772b4f Compare June 21, 2016 07:11
@xabbuh
Copy link
Member Author

xabbuh commented Jun 21, 2016

@javiereguiluz I updated the wording in this PR too.

@javiereguiluz
Copy link
Member

Great! Thanks.

@javiereguiluz
Copy link
Member

Status: Reviewed

@wouterj
Copy link
Member

wouterj commented Jun 21, 2016

👍

@wouterj wouterj merged commit 2772b4f into symfony:2.7 Jun 21, 2016
wouterj added a commit that referenced this pull request Jun 21, 2016
This PR was merged into the 2.7 branch.

Discussion
----------

[Contributing][Code] fix list item terminators

Commits
-------

2772b4f [Contributing][Code] fix list item terminators
@xabbuh xabbuh deleted the contributing-items branch June 22, 2016 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants