Caution about impersonation not compatible with pre authenticated #6673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| User impersonation is not compatible with | ||
| :doc:`pre Authenticated firewalls</cookbook/security/pre_authenticated>`. The | ||
| reason is that impersonation requires the authentication state to be maintained | ||
| server-side but pre Authenticated information (``SSL_CLIENT_S_DN_Email``, |
There was a problem hiding this comment.
pre Authenticated information -> preauthenticated information or pre-authenticated information
|
👍 Status: reviewed |
|
👍 |
wouterj
added a commit
that referenced
this pull request
Jul 2, 2016
…henticated (pasdeloup) This PR was merged into the 2.7 branch. Discussion ---------- Caution about impersonation not compatible with pre authenticated Caution added to close Symfony issue #2172 according to @fabpot comment in the Symfony #19059 PR. I also improved the similar caution about REMOTE_USER to make it global. Commits ------- b5354e5 fix pre Authenticated -> pre-authenticated f4249f3 improve caution about impersonation not compatible with pre authenticated firewalls
wouterj
added a commit
that referenced
this pull request
Jul 2, 2016
|
Thank you @pasdeloup! This is a very nice caution, explaining just enough to know why this aren't supported without being too verbose. I've made some very minor rewordings in dd3f08f after merging this PR. If you don't agree, feel free to comment. Thanks again! |
|
Thanks, it's better like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution added to close Symfony issue #2172 according to @fabpot comment in the Symfony #19059 PR.
I also improved the similar caution about REMOTE_USER to make it global.