CheckStyle in Voters cookbook #6674
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -147,10 +147,10 @@ would look like this:: | |||
| } | |||
|
|
|||
| // you know $subject is a Post object, thanks to supports | |||
| /** @var Post $post */ | |||
| /* @var Post $post */ | |||
There was a problem hiding this comment.
this change has to be reverted. Seems like a bug in PHP CS Fixer
There was a problem hiding this comment.
Change made by phpdoc_to_comment fixer (Symfony level)
Docblocks should only be used on structural elements.
There was a problem hiding this comment.
Ah, that rule isn't used by Symfony. Please disable that fixer :)
|
The other change is correct, let's merge 👍 |
|
File changed |
|
Status: Reviewed |
|
👍 |
|
Thanks @JakeFr! I've merged your PR in the 2.7 version of the docs (the oldest version we still maintain) and I'll merge it up to the 3.2 docs from there. |
wouterj
added a commit
that referenced
this pull request
Jun 24, 2016
This PR was submitted for the 3.1 branch but it was merged into the 2.7 branch instead (closes #6674). Discussion ---------- CheckStyle in Voters cookbook Hello! Apply fixes done by php-cs-fixer (Symfony level) after copy/paste this code sample in a project Commits ------- 9c5a0ba CheckStyle in Voters cookbook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Apply fixes done by php-cs-fixer (Symfony level) after copy/paste this code sample in a project