Skip to content

[Serializer] Document the encoders #6684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2016
Merged

Conversation

GuilhemN
Copy link
Contributor

Q A
Doc fix? no
New docs? yes
Applies to 2.7 -> master
Fixed tickets

Extracted from #6428

@@ -44,7 +44,7 @@ Usage

Using the Serializer component is really simple. You just need to set up
the :class:`Symfony\\Component\\Serializer\\Serializer` specifying
which Encoders and Normalizer are going to be available::
which Encoders and Normalizers are going to be available::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would do the opposite and use "encoders" and "normalizers" here.

@ogizanagi
Copy link
Contributor

Should we document the context options used by each of the built-in encoders ?

@GuilhemN
Copy link
Contributor Author

GuilhemN commented Jul 5, 2016

@xabbuh Thanks for the comments, they should be fixed now.

@ogizanagi I won't have the time to do much more for now but of course it could be a great addition !

@xabbuh
Copy link
Member

xabbuh commented Jul 6, 2016

👍

Status: Reviewed

@GuilhemN
Copy link
Contributor Author

GuilhemN commented Jul 6, 2016

@xabbuh i forgot your last comment, i'll move the custom encoders section to its own cookbook tonight.
Status: Needs work

@GuilhemN
Copy link
Contributor Author

I moved the Custom encoders section to its own cookbook. @xabbuh is it still ok for you ? :)

Status: Needs review


* :doc:`/cookbook/serializer`
* :doc:`/cookbook/serializer/introduction`
Copy link
Contributor Author

@GuilhemN GuilhemN Jul 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this name, if someone has a better idea...

@GuilhemN GuilhemN force-pushed the ENCODERS branch 2 times, most recently from 5f18a6a to c144474 Compare July 19, 2016 13:27
@weaverryan weaverryan merged commit dbdbf68 into symfony:2.7 Sep 18, 2016
weaverryan added a commit that referenced this pull request Sep 18, 2016
…ick, weaverryan)

This PR was merged into the 2.7 branch.

Discussion
----------

[Finishing][Serializer] Document the encoders

Finishing #6684 - just opening the PR to review and run tests.

Commits
-------

10b2fa3 Minor language tweaks
f99663a removing cookbook entries
73172c6 updating links
33e5b76 Moving files into the new structure
2c66c83 Merge branch 'ENCODERS' of https://github.com/Ener-Getick/symfony-docs into Ener-Getick-ENCODERS
dbdbf68 [Serializer] Document the encoders
@weaverryan
Copy link
Member

Merged via #6976. Thanks @Ener-Getick!

@GuilhemN
Copy link
Contributor Author

Thanks ! Sorry i didn't take the time to solve the conflicts...

@GuilhemN GuilhemN deleted the ENCODERS branch September 19, 2016 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants