Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-added notes about previous versions in OptionsResolver component #6703

Closed
wants to merge 1 commit into from

Conversation

mickaelandrieu
Copy link
Contributor

@mickaelandrieu mickaelandrieu commented Jul 1, 2016

On OptionsResolver component documentation, we have a Notes on previous versions section after Symfony 2.6.

Since Symfony 2.8 docs, this section is empty, so I suggest to remove it for version 3.x and probably re-add it in 2.8.

@wouterj
Copy link
Member

wouterj commented Jul 1, 2016

As explained in #6703 I'm 👎 on this PR. See also #4774

@mickaelandrieu
Copy link
Contributor Author

mickaelandrieu commented Jul 1, 2016

@wouterj #afaik Symfony 2.8 is still maintained right ? Did you say we should keep an empty section Notes on Previous Versions ? => ignore this comment please ! I agree with you on #6702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants