Cache Component: Fix SQLite3Cache instanciation #6717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Looks completely valid to me: https://github.com/doctrine/cache/blob/master/lib/Doctrine/Common/Cache/SQLite3Cache.php Thanks for submitting the fix and congratz with your first contribution! (it looks perfect) Status: reviewed |
|
👍 nice catch! Thanks @ReDnAxE. |
|
Thanks again @ReDnAxE! Your first contribution has now made it in the repository. I hope to see you back with more contributions! |
wouterj
added a commit
that referenced
this pull request
Jul 7, 2016
This PR was merged into the 3.1 branch. Discussion ---------- Cache Component: Fix SQLite3Cache instanciation My first small contribution ^^ `new SQLite3Cache()` instead of `new SQLite3()` according to the use statement Commits ------- faa3447 Cache Component: Fix SQLite3Cache instanciation
|
Thank you @wouterj and @javiereguiluz for your review, yes I hope also :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first small contribution ^^
new SQLite3Cache()instead ofnew SQLite3()according to the use statement