Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Finder] Fixed typo in RealPath method on SplFileInfo class #6721

Merged
merged 1 commit into from
Jul 7, 2016

Conversation

acrobat
Copy link
Contributor

@acrobat acrobat commented Jul 6, 2016

The getRealPath method in SplFileInfo has a capital letter for getRealpath. See SplFileInfo::getRealPath

Found this typo when implementing the finder component and copying the example .

@wouterj
Copy link
Member

wouterj commented Jul 6, 2016

Seems like a valid change to me. 👍

status: reviewed

@javiereguiluz
Copy link
Member

👍 nice catch @acrobat!

@wouterj
Copy link
Member

wouterj commented Jul 7, 2016

Thanks Jeroen!

@wouterj wouterj merged commit 4132a97 into symfony:2.7 Jul 7, 2016
wouterj added a commit that referenced this pull request Jul 7, 2016
…ss (acrobat)

This PR was merged into the 2.7 branch.

Discussion
----------

[Finder] Fixed typo in RealPath method on SplFileInfo class

The getRealPath method in SplFileInfo has a capital letter for getReal**p**ath. See [SplFileInfo::getRealPath](http://php.net/manual/en/splfileinfo.getrealpath.php)

Found this typo when implementing the finder component and copying the example .

Commits
-------

4132a97 Fixed typo in RealPath method on SplFileInfo class
@acrobat acrobat deleted the finder_typo_fix branch July 8, 2016 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants