Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add little caution to add service id for @Route annotation #6734

Merged
merged 2 commits into from
Jul 9, 2016
Merged

Add little caution to add service id for @Route annotation #6734

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac6b008
Add warning about a pitfall where the controller seems to be instanti…
DHager Feb 10, 2016
93bb21c
Merge caution with annotations tip
wouterj Jul 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cookbook/controller/service.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,8 @@ the route ``_controller`` value:
.. tip::

You can also use annotations to configure routing using a controller
defined as a service. See the `FrameworkExtraBundle documentation`_ for
defined as a service. Make sure you specify the service ID in the
``@Route`` annotation. See the `FrameworkExtraBundle documentation`_ for
details.

.. tip::
Expand Down Expand Up @@ -338,4 +339,4 @@ controller:

.. _`Controller class source code`: https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/Controller/Controller.php
.. _`base Controller class`: https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/Controller/Controller.php
.. _`FrameworkExtraBundle documentation`: https://symfony.com/doc/current/bundles/SensioFrameworkExtraBundle/annotations/routing.html
.. _`FrameworkExtraBundle documentation`: https://symfony.com/doc/current/bundles/SensioFrameworkExtraBundle/annotations/routing.html#controller-as-service