Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix FlattenException namespace #6797

Closed
wants to merge 1 commit into from
Closed

Conversation

alchimik
Copy link
Contributor

No description provided.

@@ -69,7 +69,9 @@ Our code is now much more concise and surprisingly more robust and more
powerful than ever. For instance, use the built-in ``ExceptionListener`` to
make your error management configurable::

$errorHandler = function (HttpKernel\Exception\FlattenException $exception) {
use Symfony\Component\Debug\Exception\FlattenException;
Copy link

@snoek09 snoek09 Jul 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code example is inconsistent now since there's a use statement for FlattenException but not for ExceptionListener (line 79). I think in this case the full path for FlattenException should be updated instead of using a use statement.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tweaked this - good catch :)

@snoek09
Copy link

snoek09 commented Jul 31, 2016

👍

Status: Reviewed

Thanks @alchimik

@weaverryan
Copy link
Member

Very good bug fixes - thank you @alchimik!

@weaverryan weaverryan closed this in f71b7bd Aug 2, 2016
@alchimik alchimik deleted the patch-4 branch August 2, 2016 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants