Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove colloquialism "hold on" #6805

Closed
wants to merge 2 commits into from
Closed

Remove colloquialism "hold on" #6805

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
962f6bb
Remove colloquialism "hold on"
Aug 1, 2016
5d93331
Update dynamic_form_modification.rst
Aug 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion form/dynamic_form_modification.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ take a look at the :doc:`Form Events </form/events>` documentation.
Customizing your Form Based on the Underlying Data
--------------------------------------------------

Before jumping right into dynamic form generation, hold on and recall what
Before starting with dynamic form generation, recall what
Copy link

@snoek09 snoek09 Aug 1, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree on the tone which is slightly different here compared to the rest of the documentation.
If hold on is removed I think jumping right into should also be changed as it relates to each other.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I'll think of something in place of jumping right into and update the PR.

a bare form class looks like::
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The double semicolon (::) should be kept before a code example.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I didn't know that. I'll fix it and update the PR.


// src/AppBundle/Form/Type/ProductType.php
Expand Down