Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created the main article about "deployment" #6814

Merged
merged 4 commits into from
Aug 20, 2016

Conversation

javiereguiluz
Copy link
Member

In the new Symfony Doc structure, top-level pages (e.g. deployment.rst) are "cornerstone pages" and not mere index pages listing other articles. During the doc reorganization we moved most articles, but some were missing, like this deployment article.

manually taking other steps (see `Common Post-Deployment Tasks`_).

Using Build Scripts and other Tools
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a section above this, something like:

Deploying via a "Platform as a Service"

It would have a sentence or two, and then links to our articles about this, Heroku, platform.sh, etc.

@weaverryan
Copy link
Member

One minor comment

👍

Status: Reviewed


.. code-block:: bash

$ php app/check.php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: change this in 3.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it after the merge :)

@javiereguiluz
Copy link
Member Author

I've added the mini section about PaaS providers. This is ready to be merged. Thanks!

@wouterj
Copy link
Member

wouterj commented Aug 5, 2016

So now we have 2 sections with a list of doc references, linking to exactly the same set of articles. Not sure if I like that...

@javiereguiluz
Copy link
Member Author

@wouterj 👍, I've removed the "Learn More" section because it only contained the PaaS articles.

@weaverryan weaverryan merged commit 6f2ff9e into symfony:2.7 Aug 20, 2016
weaverryan added a commit that referenced this pull request Aug 20, 2016
This PR was merged into the 2.7 branch.

Discussion
----------

Created the main article about "deployment"

In the new Symfony Doc structure, top-level pages (e.g. `deployment.rst`) are "cornerstone pages" and not mere index pages listing other articles. During the doc reorganization we moved most articles, but some were missing, like this deployment article.

Commits
-------

6f2ff9e Removed the "Learn more" section
f3a960e Created a "Platform as a Service" section
26cee5d Fixed a reference
0515cb5 Created the main article about "deployment"
@weaverryan
Copy link
Member

Thanks Javier! Tests failed after your last change because now the paas articles weren't included in any index. I replaced the links with an index - I think it should work just fine.

@javiereguiluz javiereguiluz deleted the move_deployment branch May 24, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants