[Debug] Added configuration reference for new debug options #6870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
force-pushed
the
debug-plus-plus
branch
2 times, most recently
from
0a6fe77 to
cc5c089
Compare
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Aug 17, 2016
This PR was merged into the 3.2-dev branch. Discussion ---------- [Debug] Better error handling | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | - | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#6870 1. Send the raw exception in the log context instead of custom formatting 2. Add config option to log/throw in Symfony all PHP errors 3. Always use an exception when a PHP error occurs 4. Expand exception in the log context in the web developer toolbar 5. Use the dumper to dump log context in the web developer toolbar --- I used the following code to produce screenshots: ```php public function indexAction(Request $request) { $this->get('logger')->info('A log message with an exception', ['exception' => new \Exception('this exception will be logged')]); error_reporting(0); for ($i=0; $i < 15; $i++) { if ($i == 5) { error_reporting(E_ALL); } if ($i == 10) { error_reporting(0); } trigger_error("Trigger error avec E_USER_NOTICE", E_USER_NOTICE); } error_reporting(E_ALL); @trigger_error("trigger_error avec E_USER_DEPRECATED", E_USER_DEPRECATED); trigger_error("trigger_error avec E_USER_DEPRECATED (not silent)", E_USER_DEPRECATED); // ... ```    Commits ------- 8f24549 [Debug] Better error handling
xabbuh
reviewed
Sep 22, 2016
| **type**: ``boolean`` **default**: ``%kernel.debug%`` | ||
|
|
||
| Throw PHP errors as ``\ErrorException`` instances. The parameter | ||
| ``debug.error_handler.throw_at`` control the threshold. |
|
Please also add |
lyrixx
force-pushed
the
debug-plus-plus
branch
from
cc5c089 to
7ea70c8
Compare
|
👍 Status: Reviewed |
wouterj
added a commit
that referenced
this pull request
Oct 6, 2016
…ions (lyrixx) This PR was merged into the master branch. Discussion ---------- [Debug] Added configuration reference for new debug options Commits ------- 7ea70c8 [Debug] Added configuration reference for new debug options
wouterj
added a commit
that referenced
this pull request
Oct 6, 2016
|
Thanks @lyrixx, it looks perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.