Error in CSRF example code snippet #6881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something's wrong when I tried this code: `$formFactory = Forms::createFormFactoryBuilder()` ` // ...` ` ->addExtension(new CsrfExtension($csrfStorage))` ` ->getFormFactory();` Constructing a `CsrfExtension` requires a `CsrfTokenManagerInterface` as an argument (see symfony/form/Extension/Csrf/CsrfExtension.php, line 24). The `$csrfStorage` in `addExtension(new CsrfExtension($csrfStorage)`, has a class that implements `TokenStorageInterface` (see symfony/security-csrf/TokenStorage/SessionStorageToken.php, line 22). So I replaced it with `$csrfManager` that has class that implement `CsrfTokenManagerInterface`. (see symfony/security-csrf/CsrfTokenManager.php, line 24)
|
Thanks for your detailed PR description @makoru-hikage! Fyi, I've merged your PR into the 2.7 version of the docs and will merge 2.7 into the newer versions later today. |
wouterj
added a commit
that referenced
this pull request
Aug 17, 2016
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #6881). Discussion ---------- Error in CSRF example code snippet Something's wrong when I tried this code: ``` $session = new Session(); $csrfGenerator = new UriSafeTokenGenerator(); $csrfStorage = new SessionTokenStorage($session); $csrfManager = new CsrfTokenManager($csrfGenerator, $csrfStorage); $formFactory = Forms::createFormFactoryBuilder() // ... ->addExtension(new CsrfExtension($csrfStorage)) ->getFormFactory(); ``` Constructing a `CsrfExtension` requires a `CsrfTokenManagerInterface` as an argument (see symfony/form/Extension/Csrf/CsrfExtension.php, line 47). The `$csrfStorage` in `addExtension(new CsrfExtension($csrfStorage)`, has a class that implements `TokenStorageInterface` (see symfony/security-csrf/TokenStorage/SessionStorageToken.php, line 22). So I replaced it with `$csrfManager` that has class that implements `CsrfTokenManagerInterface`. (see symfony/security-csrf/CsrfTokenManager.php, line 24) Commits ------- 80c09dd Error in CSRF example code snippet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something's wrong when I tried this code:
Constructing a
CsrfExtensionrequires aCsrfTokenManagerInterfaceas an argument (see symfony/form/Extension/Csrf/CsrfExtension.php, line 47).The
$csrfStorageinaddExtension(new CsrfExtension($csrfStorage), has a class that implementsTokenStorageInterface(see symfony/security-csrf/TokenStorage/SessionStorageToken.php, line 22).So I replaced it with
$csrfManagerthat has class that implementsCsrfTokenManagerInterface. (see symfony/security-csrf/CsrfTokenManager.php, line 24)