[Routing] Add doc about unicode requirements #6890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
route-unicode
branch
2 times, most recently
from
b2154f8
to
c53742f
Compare
nicolas-grekas
changed the title
| of just a single byte. Unicode matching is also automatically enabled | ||
| whenever the route or a requirement contains a non-ASCII UTF-8 character or | ||
| a `PCRE Unicode property`_ (``\p{xx}``, ``\P{xx}`` or ``\X``). | ||
|
|
There was a problem hiding this comment.
I think we need an example with the * prefix to make things real clear.
nicolas-grekas
force-pushed
the
route-unicode
branch
3 times, most recently
from
d2af1c2
to
e129c00
Compare
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Aug 25, 2016
…s (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [Routing] Add seamless support for unicode requirements | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #3629, #5236, #19562 | License | MIT | Doc PR | symfony/symfony-docs#6890 This PR adds unicode support to route matching and generation by automatically adding the `u` modifier to regexps that use either unicode characters or unicode enabled character classes (e.g. `\p...` `\x{...}` `\X`). As a side note, if one wants to match a single unicode character (vs a single byte), one should use `\PM` or `\X` instead of `.` *or* set the `unicode` parameter to true. Commits ------- a829d34 [Routing] Add seamless support for unicode requirements
symfony-splitter
pushed a commit
to symfony/routing
that referenced
this pull request
Aug 25, 2016
…s (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [Routing] Add seamless support for unicode requirements | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #3629, #5236, #19562 | License | MIT | Doc PR | symfony/symfony-docs#6890 This PR adds unicode support to route matching and generation by automatically adding the `u` modifier to regexps that use either unicode characters or unicode enabled character classes (e.g. `\p...` `\x{...}` `\X`). As a side note, if one wants to match a single unicode character (vs a single byte), one should use `\PM` or `\X` instead of `.` *or* set the `unicode` parameter to true. Commits ------- a829d34 [Routing] Add seamless support for unicode requirements
|
👍 Status: reviewed A fantastic feature and perfectly documented! Thanks @nicolas-grekas (Note: there are some minor formatting issues in this commit: in RST, code literals must be wrapped with double backticks instead of Markdown's single backticks). |
nicolas-grekas
force-pushed
the
route-unicode
branch
from
e129c00
to
75ed392
Compare
|
Thank you @nicolas-grekas. |
xabbuh
added a commit
that referenced
this pull request
Sep 21, 2016
…rekas) This PR was merged into the master branch. Discussion ---------- [Routing] Add doc about unicode requirements Ref. symfony/symfony#19604 Commits ------- 75ed392 Add doc about unicode requirements
xabbuh
added a commit
that referenced
this pull request
Sep 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. symfony/symfony#19604