Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VarDumper] Doc for the Data::seek() method #6891

Merged
merged 1 commit into from
Sep 21, 2016

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Aug 19, 2016

fabpot added a commit to symfony/symfony that referenced this pull request Aug 19, 2016
…ctures (nicolas-grekas)

This PR was merged into the 3.2-dev branch.

Discussion
----------

[VarDumper] Allow dumping subparts of cloned Data structures

| Q             | A
| ------------- | ---
| Branch?       | master
| New feature?  | yes
| Tests pass?   | yes
| License       | MIT
| Doc PR     | symfony/symfony-docs#6891

ping @wouterj: with this, we'll be able to dump only the trace for deprecations in #19614 instead of being forced to dump the full exception right now. See test case.
We'd do `{{ profiler_dump(log.context.seek('trace')) }}` in `logger.html.twig`.

Commits
-------

8f2f440 [VarDumper] Allow dumping subparts of cloned Data structures
@wouterj
Copy link
Member

wouterj commented Aug 28, 2016

👍
status: reviewed

@javiereguiluz
Copy link
Member

I'm not sure the following can be fully understood --> a subkey of some arrays, objects or resources. ... but I think this is hard to explain without an example. What about:

:method:`Symfony\\Component\\VarDumper\\Cloner\\Data::seek`
    Dumps contents partially starting from the given key (for arrays) or property name
    (for objects).

Unrelated to this, but I'd also like to change the following:

Allows limiting ... -> Limits ...
Allows removing ... -> Removes ...
Allows dumping ...  -> Dumps ...

@nicolas-grekas
Copy link
Member Author

@javiereguiluz updated

@javiereguiluz
Copy link
Member

👍

Status: reviewed

@xabbuh
Copy link
Member

xabbuh commented Sep 21, 2016

Thank you @nicolas-grekas.

@xabbuh xabbuh merged commit cb66d83 into symfony:master Sep 21, 2016
xabbuh added a commit that referenced this pull request Sep 21, 2016
…ekas)

This PR was merged into the master branch.

Discussion
----------

[VarDumper] Doc for the Data::seek() method

Ref. symfony/symfony#19672

Commits
-------

cb66d83 [VarDumper] Doc for the Data::seek() method
xabbuh added a commit that referenced this pull request Sep 21, 2016
@nicolas-grekas nicolas-grekas deleted the vardump-seek branch September 23, 2016 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants