fixing $formatLevelMap array values #6895
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logically the values of `$formatLevelMap` array were switched, "LogLevel::CRITICAL" key should have value `ConsoleLogger::ERROR` and `LogLevel::DEBUG` key should have value `ConsoleLogger::INFO`
|
Seems like a correct fix to me 👍 |
|
👍 |
|
Good catch, thanks @zrashwani. |
xabbuh
added a commit
that referenced
this pull request
Sep 21, 2016
This PR was submitted for the 3.1 branch but it was merged into the 2.7 branch instead (closes #6895). Discussion ---------- fixing $formatLevelMap array values Logically the values of `$formatLevelMap` array were switched, `LogLevel::CRITICAL` key should have value `ConsoleLogger::ERROR` and `LogLevel::DEBUG` key should have value `ConsoleLogger::INFO` Commits ------- 0f56c3c fixing $formatLevelMap array values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logically the values of
$formatLevelMaparray were switched,LogLevel::CRITICALkey should have valueConsoleLogger::ERRORandLogLevel::DEBUGkey should have valueConsoleLogger::INFO