Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update voters.rst #6897

Closed
wants to merge 2 commits into from
Closed

Update voters.rst #6897

wants to merge 2 commits into from

Conversation

asandjivy
Copy link
Contributor

No description provided.

@wouterj
Copy link
Member

wouterj commented Aug 28, 2016

Makes sense to me 👍

status: reviewed

@javiereguiluz
Copy link
Member

👍

If possible, let's replace this:

The ``denyAccessUnlessGranted()`` function and the ``isGranted()`` function ...

by this:

The ``denyAccessUnlessGranted()`` and ``isGranted()`` functions ...

@asandjivy
Copy link
Contributor Author

I agree with you. it's better :)

@asandjivy
Copy link
Contributor Author

ok done 👍

xabbuh added a commit that referenced this pull request Sep 21, 2016
This PR was submitted for the 3.1 branch but it was merged into the 2.8 branch instead (closes #6897).

Discussion
----------

Update voters.rst

Commits
-------

80e84b9 Update voters.rst
xabbuh added a commit that referenced this pull request Sep 21, 2016
@xabbuh
Copy link
Member

xabbuh commented Sep 21, 2016

Thanks @asandjivy! I have merged your changes into the 2.8 branch and made some minor tweaks in b5fe1b4.

@xabbuh xabbuh closed this Sep 21, 2016
xabbuh added a commit that referenced this pull request Sep 21, 2016
* 2.8: (32 commits)
  [#6989] some minor tweaks
  Added paths options in Framework::translator configuration
  [#6934] add remember me response listener
  Update events.rst
  [#6897] some tweaks after review
  Update voters.rst
  [#6920] some tweaks after review
  Note about bundle priority for PrependExtensionInterface
  [#6926] some tweaks after review
  [#6905] rewrite code example to cover the setter
  Change example of ignoring dependencies for yaml
  [FormComponent]Fix wrong mention in side note
  Article about logout.
  Clarify by_reference use
  Use Terminal lexer for console examples
  Update entity_provider.rst
  fixing $formatLevelMap array values
  Fix subject/verb agreement
  Fixed directory name type
  fix link role syntax
  ...
xabbuh added a commit that referenced this pull request Sep 21, 2016
* 3.1: (50 commits)
  Update heroku.rst
  [#6989] some minor tweaks
  Added paths options in Framework::translator configuration
  [#6934] add remember me response listener
  Update events.rst
  [#6897] some tweaks after review
  Update voters.rst
  [#6920] some tweaks after review
  Note about bundle priority for PrependExtensionInterface
  [#6926] some tweaks after review
  [#6905] rewrite code example to cover the setter
  Change example of ignoring dependencies for yaml
  [FormComponent]Fix wrong mention in side note
  Article about logout.
  Clarify by_reference use
  Use Terminal lexer for console examples
  Update entity_provider.rst
  fixing $formatLevelMap array values
  Use the standard cache and logs dir for the micro kernel example
  Fix subject/verb agreement
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants