[Controller Description] Fix typos and class link #6913
Conversation
rendler-denis
commented
Aug 24, 2016
rendler-denis
commented
- fix typo in first code example from $name to $max
- add link to the Request class instead of just make the name bold
- fix typo in first code example from $name to $max - add link to the Request class instead of just make the name bold
|
Thanks for the typo fix, that's correct! However, in reStructured Text (the markup language used), you can't nest inline markup. So your code doesn't work either (see also the platform.sh build of this PR). Can you please update this PR (by adding a new commit to the patch-4 branch) to remove all markup around status: needs work |
- remove the nested mark-up referencing the HttpFoundation\Request class due to inline markup nesting not possible in the reStructured Text format
|
Hello, @wouterj! Thanks for the heads-up. I wasn't aware of this limitation and I should have checked the deployment results. It is a good lesson for the future PRs. |
|
👍 Thanks for your quick reactions! (if you have some time, please remove the single backticks around Request as well) |
- remove backticks from Request class name
|
@wouterj, changes done! :) |
|
Perfect! Thanks again Denis! Fyi, I've merged the changes in 2.7 and will merge them into the newer versions from there |
…r-denis) This PR was submitted for the 3.0 branch but it was merged into the 2.7 branch instead (closes #6913). Discussion ---------- [Controller Description] Fix typos and class link - fix typo in first code example from $name to $max - add link to the Request class instead of just make the name bold Commits ------- a0bbfae [Controller Description] Remove backticks 74addb0 [Controller] Fix nested inline markup e017723 [Controller Description] Fix typos and class link
