Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the docs about overriding services #6927

Closed
wants to merge 1 commit into from

Conversation

javiereguiluz
Copy link
Member

This fixes #6912. In Symfony 3.x we no longer use or recommend to define classes as parameters.

@HeahDude
Copy link
Contributor

👍

Status: reviewed

@xabbuh
Copy link
Member

xabbuh commented Sep 21, 2016

👍

What do you think about merging this into the 2.7 branch? Using a compiler pass is already possible in Symfony 2.7 and we then wouldn't advertise a solution we consider being a bad practice.

@xabbuh
Copy link
Member

xabbuh commented Oct 30, 2016

Sorry Javier, we somehow never managed to merge this. I am now closing here as I just merged #7090 which covered all the changes made here too.

@xabbuh xabbuh closed this Oct 30, 2016
@javiereguiluz javiereguiluz deleted the fix_6912 branch May 24, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants