Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Redirecting paragraph of Testing page #7098

Merged
merged 1 commit into from
Oct 30, 2016
Merged

Improved Redirecting paragraph of Testing page #7098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion testing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ afterwards with the ``followRedirect()`` method::
$crawler = $client->followRedirect();

If you want the client to automatically follow all redirects, you can
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShinDarth thanks for this improvement. I like it ... but I still think that the original phrase is not very good. What if we reword it as follows:

You can make the client to automatically follow all redirects by
calling the ``followRedirects()`` method before making the first request::

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok but are you sure that it should be made before the first request? I would say it simply should be made before the requests that needs to automatically follow the redirect

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 You are right. It's common to call this before the first request ... but it's not mandatory at all! Thanks.

force him with the ``followRedirects()`` method::
force them by calling the ``followRedirects()`` method before performing the request::

$client->followRedirects();

Expand Down