Update email.rst #9737
Closed
Update email.rst #9737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Above the method (line#54): public function index($name, \Swift_Mailer $mailer) a PHP Doc should be written although the IDE provides a functionality to automatically write it. 2) Below this same method, an example should be written to run it (line #85): I run this method this way: http://localhost:8000/email/username but it doesn't work, it gives this error: No route found for "GET /email/username" I think it is a bit unclear.
xabbuh
reviewed
May 18, 2018
| @@ -51,6 +51,7 @@ The Swift Mailer library works by creating, configuring and then sending | |||
| of the message and is accessible via the ``Swift_Mailer`` service. Overall, | |||
| sending an email is pretty straightforward:: | |||
|
|
|||
| // Put PHP Doc here | |||
There was a problem hiding this comment.
I do not understand what you mean with this. What kind of PHPdoc would you like to see here?
There was a problem hiding this comment.
@xabbuh
PHPDoc related to these parameters: $name, \Swift_Mailer $mailer but I understand this information is clearly irrelevant to this context.
This pull request was made when I am lost how to send an email but finally I could do it.
I am going to close it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Above the method (line#54):
public function index($name, \Swift_Mailer $mailer)
a PHP Doc should be written although the IDE provides a functionality to automatically write it.
Below this same method, an example should be written to run it (line new import resources notation issue with @ on yaml files #85):
I run this method this way: http://localhost:8000/email/username but it doesn't work, it gives this error:
No route found for "GET /email/username"
I think it is a bit unclear.