Skip to content

Remove the API version in the validator component #14016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 23, 2015

Conversation

stof
Copy link
Member

@stof stof commented Mar 22, 2015

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #13458
License MIT
Doc PR n/a

This completes the work of #13517

Thanks to the PHP version requirement bump to 5.3.9+, the BC layer can
be available all the time.
@stof stof force-pushed the remove_validator_api_version branch from d30ff4e to 9438206 Compare March 22, 2015 15:49
@fabpot
Copy link
Member

fabpot commented Mar 23, 2015

Thank you @stof.

@fabpot fabpot merged commit 9438206 into symfony:2.7 Mar 23, 2015
fabpot added a commit that referenced this pull request Mar 23, 2015
…o0h, fabpot, stof)

This PR was merged into the 2.7 branch.

Discussion
----------

  Remove the API version in the validator component

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #13458
| License       | MIT
| Doc PR        | n/a

This completes the work of #13517

Commits
-------

9438206 Complete the removal of API versions in the validator component
75088c0 [Validator] deprecated API version
0c69f69 Removed 2.5 bc layer
@stof stof deleted the remove_validator_api_version branch March 23, 2015 10:36
@stof
Copy link
Member Author

stof commented Mar 23, 2015

@fabpot @nicolas-grekas do you have any idea why the UuidValidator constants are nowcausing us an issue with deprecation, making the test fail while it was passing before this patch ?
One idea is that the class could have been loaded by a legacy test previously, where the deprecation would have been catched silently. but this would mean that the hack used to trigger deprecation for constants lazily does not actually work as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants