Skip deprecation coming from DBAL 3.2 #44231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
dbal32
branch
from
3152a2c to
647d501
Compare
|
the DbalLogger from the bridge won't even become compatible with DBAL 3.2 in a deprecation-free way. What will happen instead is that DbalLogger will stop being used by DoctrineBundle for DBAL 3.2+ and that DbalLogger will get deprecated once Symfony drops support for DBAL <3.2. So to me, the DbalLoggerTest will need to be tagged as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While waiting for doctrine/DoctrineBundle#1429 and related