[Form] Add duplicate_preferred_choices option to ChoiceType
#50934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
arnaud-deabreu
force-pushed
the
feature/preferred_choice_deduplicate
branch
2 times, most recently
from
927aed0 to
33a89bf
Compare
arnaud-deabreu
force-pushed
the
feature/preferred_choice_deduplicate
branch
from
33a89bf to
5b5d18d
Compare
There was a problem hiding this comment.
Thanks for taking care of this, @javiereguiluz should like it :)
src/Symfony/Component/Form/ChoiceList/Factory/CachingFactoryDecorator.php
Show resolved
Hide resolved
arnaud-deabreu
force-pushed
the
feature/preferred_choice_deduplicate
branch
from
5b5d18d to
3b48aba
Compare
nicolas-grekas
force-pushed
the
feature/preferred_choice_deduplicate
branch
from
3b48aba to
df00a5f
Compare
fabpot
approved these changes
Oct 5, 2023
|
Thank you @arnaud-deabreu. |
fabpot
added a commit
that referenced
this pull request
Oct 16, 2023
… choices (HeahDude) This PR was merged into the 7.0 branch. Discussion ---------- [Form] Remove deprecation layer for duplicated preferred choices | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | ~ | License | MIT Follows #50934. Commits ------- 8945228 [Form] Remove deprecation layer for duplicated preferred choices
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reintroduced layout tests as they were before #32658, is that enough? /cc @xabbuh :)
Thanks @HeahDude for your mentoring!