-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mailer] Implement Postal mailer #57903
Conversation
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
src/Symfony/Component/Mailer/Bridge/Postal/Tests/Transport/PostalApiTransportTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/Postal/Transport/PostalApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/Postal/Transport/PostalApiTransport.php
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/Postal/Transport/PostalTransportFactory.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've suggested a small CS fix.
src/Symfony/Component/Mailer/Bridge/Postal/Transport/PostalApiTransport.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small CS changes, the code itself looks good to me besides that
src/Symfony/Component/Mailer/Bridge/Postal/Transport/PostalApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/Postal/Transport/PostalApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/Postal/Transport/PostalApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/Postal/Transport/PostalApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/Postal/Transport/PostalApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/Postal/Transport/PostalApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/Postal/Transport/PostalApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/Postal/Transport/PostalTransportFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/Postal/Transport/PostalApiTransport.php
Outdated
Show resolved
Hide resolved
Thank you @jonasclaes. |
@jonasclaes Can you create a recipe on https://github.com/symfony/recipes? |
All done! Let me know if I missed something. First time! |
This will implement the Postal mailer.
API docs: https://apiv1.postalserver.io/controllers/send/message.html
Docs: symfony/symfony-docs#20088