Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mailer] Implement Postal mailer #57903

Merged
merged 1 commit into from
Aug 11, 2024
Merged

[Mailer] Implement Postal mailer #57903

merged 1 commit into from
Aug 11, 2024

Conversation

jonasclaes
Copy link
Contributor

@jonasclaes jonasclaes commented Aug 1, 2024

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
License MIT

This will implement the Postal mailer.

API docs: https://apiv1.postalserver.io/controllers/send/message.html

Docs: symfony/symfony-docs#20088

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested a small CS fix.

Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small CS changes, the code itself looks good to me besides that

@fabpot
Copy link
Member

fabpot commented Aug 11, 2024

Thank you @jonasclaes.

@fabpot fabpot merged commit cf3dfb6 into symfony:7.2 Aug 11, 2024
8 of 10 checks passed
@fabpot
Copy link
Member

fabpot commented Aug 11, 2024

@jonasclaes Can you create a recipe on https://github.com/symfony/recipes?

@jonasclaes
Copy link
Contributor Author

@jonasclaes Can you create a recipe on https://github.com/symfony/recipes?

symfony/recipes#1332

All done! Let me know if I missed something. First time!

@fabpot fabpot mentioned this pull request Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants