[RemoteEvent][Webhook] Fix SendgridRequestParser and SendgridPayloadConverter
#59376
+18
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verter in case of missing sg_message_id
OskarStark
changed the title
SendgridRequestParser and SendgridPayloadConverter
|
Thank you @ericabouaf. |
This was referenced Jan 29, 2025
Merged
Merged
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://www.twilio.com/docs/sendgrid/for-developers/tracking-events/event#event-objects, not all webhook events contains a
sg_message_idin the payload. In the case of a delayed or asynchronous bounce, the message ID will be unavailable.The current implementation rejects the webhook call with "Payload is malformed".
We should use the always present
sg_event_idinstead.For BC reasons, I did not want to change the id of the RemoteEvent, so I kept
sg_message_idif present, but fallback tosg_event_idinstead so that the webhook is not rejected.