[HttpClient] Fix uploading files > 2GB #59654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jan 30, 2025
| @@ -316,6 +316,9 @@ public function request(string $method, string $url, array $options = []): Respo | |||
| } | |||
|
|
|||
| foreach ($curlopts as $opt => $value) { | |||
| if (\CURLOPT_INFILESIZE === $opt && $value >= 1 << 31) { | |||
| $opt = 115; // 115 === CURLOPT_INFILESIZE_LARGE, but it's not defined in PHP | |||
There was a problem hiding this comment.
Out of curiosity: Can we add this constant in php-src/ext-curl? I checked the code there, but I can only find CURLOPT_INFILESIZE, so it may mainly be a copy paste. The problem is, that I did not find the definition for CURLOPT_INIFILESIZE to be 14 to be able to add 115 for the new constant 🤔 Any hints?
There was a problem hiding this comment.
php-src could add the const for sure, but that won't solve the issue for us since this would be for PHP 8.5 earlier.
There was a problem hiding this comment.
but that won't solve the issue for us since this would be for PHP 8.5 earlier.
that's cristal clear, I know 👍
nicolas-grekas
added a commit
that referenced
this pull request
Feb 4, 2025
…ported (xabbuh) This PR was merged into the 6.4 branch. Discussion ---------- [HttpClient] pass CURLOPT_INFILESIZE_LARGE only when supported | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT following #59654 Commits ------- 018a384 pass CURLOPT_INFILESIZE_LARGE only when supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: